kwin commented on code in PR #2800:
URL: https://github.com/apache/jackrabbit-oak/pull/2800#discussion_r2945646346
##########
pom.xml:
##########
@@ -35,6 +35,8 @@
<skip.deployment>true</skip.deployment>
<sonar.organization>apache</sonar.organization>
<sonar.host.url>https://sonarcloud.io</sonar.host.url>
+ <!-- this project uses cross-module reports with one aggregate,
https://docs.sonarsource.com/sonarcloud/enriching/test-coverage/java-test-coverage/#add-coverage-in-a-multi-module-maven-project
-->
+
<sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/target/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
Review Comment:
This needs to be set for each module individually otherwise the
non-aggregate report is used
(https://docs.sonarsource.com/sonarqube-server/analyzing-source-code/test-coverage/java-test-coverage#multi-module-maven-project).
Our hierarchy is different from the example in the Sonar documentation that
the submodules don't inherit from the root POM but from the parent, therefore
move the property there similar to
https://github.com/apache/jackrabbit/blob/024bca3806907cff6abcf2f922149728b1cd08c0/jackrabbit-parent/pom.xml#L84.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
