rishabhdaim commented on code in PR #2819: URL: https://github.com/apache/jackrabbit-oak/pull/2819#discussion_r3009357129
########## oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/OakCacheStatsAdapter.java: ########## @@ -0,0 +1,93 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.jackrabbit.oak.cache; + +import java.util.Map; + +import org.apache.jackrabbit.guava.common.cache.CacheStats; +import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; + +/** + * Exposes an {@link OakCache}'s statistics via the {@link org.apache.jackrabbit.oak.api.jmx.CacheStatsMBean} + * interface by bridging {@link OakCacheStats} to the Guava shim {@link CacheStats} expected + * by {@link AbstractCacheStats}. + * + * <p>The Guava return type from {@link #getCurrentStats()} is kept until TASK-16 updates + * the base class to use {@link OakCacheStats} directly.</p> Review Comment: This would increase the scope of changes to many modules. Doing this incrementally would require this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
