smiroslav commented on code in PR #2850:
URL: https://github.com/apache/jackrabbit-oak/pull/2850#discussion_r3118551168
##########
oak-segment-azure/src/main/java/org/apache/jackrabbit/oak/segment/azure/v8/AzurePersistenceV8.java:
##########
@@ -122,7 +131,8 @@ private CloudAppendBlob getAppendBlob(String path) throws
IOException {
}
}
- private static void attachRemoteStoreMonitor(RemoteStoreMonitor
remoteStoreMonitor) {
+ private void attachRemoteStoreMonitor(RemoteStoreMonitor
remoteStoreMonitor) {
+ this.remoteStoreMonitor.set(remoteStoreMonitor);
Review Comment:
Thanks @jsedding for the suggestion.
I am thinking since the method is public, theoretically it could be called
more than once for the same persistence, not that I see how it would make
sense. I am a bit reluctant to add that set-once guard since we do not document
this behaviour in the interface.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
