reschke commented on code in PR #2879:
URL: https://github.com/apache/jackrabbit-oak/pull/2879#discussion_r3159501330
##########
oak-core-spi/src/main/java/org/apache/jackrabbit/oak/cache/api/CacheBuilder.java:
##########
@@ -271,9 +272,6 @@ private Caffeine<K, V> configureCaffeineBuilder() {
caffeineBuilder = caffeineBuilder.recordStats();
}
if (evictionListener != null) {
Review Comment:
So that "just" makes setting the executor independant of the
evictionListener?
##########
oak-core-spi/src/test/java/org/apache/jackrabbit/oak/cache/impl/CacheBuilderTest.java:
##########
@@ -178,6 +178,33 @@ public void statsReturnsCorrectHitMissCounts() {
Assert.assertEquals(1, stats.missCount());
}
Review Comment:
I assume these tests fail without the change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
