joerghoh commented on code in PR #2901:
URL: https://github.com/apache/jackrabbit-oak/pull/2901#discussion_r3259619986
##########
oak-segment-remote/src/main/java/org/apache/jackrabbit/oak/segment/remote/persistentcache/RemotePersistentCacheService.java:
##########
@@ -93,6 +95,12 @@ private PersistentCache createPersistentCache(Configuration
configuration, Close
PersistentDiskCache persistentDiskCache = new
PersistentDiskCache(new File(configuration.diskCacheDirectory()),
configuration.diskCacheMaxSizeMB(), diskCacheIOMonitor);
closer.register(persistentDiskCache);
+ // OAK-12212: expose the kill switch for the cacheSize-accounting
+ // fix so it can be flipped at runtime via the Whiteboard.
+ registerCloseable(osgiWhiteboard.register(FeatureToggle.class,
Review Comment:
Yes, I think that will work as well (it's using a ``FeatureToggle`` behind
the scenes); bu I find that current ``Feature`` implementation a bit
non-obvious (especially what the default value is in the case that the feature
is not explicitly configured).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
