dulvac commented on code in PR #3059: URL: https://github.com/apache/jackrabbit-oak/pull/3059#discussion_r3711294696
########## oak-core-spi/src/main/java/org/apache/jackrabbit/oak/spi/audit/AuditEventImpl.java: ########## @@ -0,0 +1,76 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.jackrabbit.oak.spi.audit; + +import java.util.Map; + +import org.jetbrains.annotations.NotNull; + +/** + * Package-private immutable {@link AuditEvent} backing the + * {@link AuditEvent#of(String, String, Map) AuditEvent.of} static factories. + * <p> + * Not part of the SPI surface — consumers always see the bare + * {@code AuditEvent} interface. Keeping the impl package-private is the + * core of item 3 (drop typed event hierarchy): consumers cannot + * {@code instanceof}-check or downcast; discrimination is via + * {@link AuditEvent#getDomain()} + {@link AuditEvent#getType()}. + * <p> + * The {@code payload} Map is expected to already be immutable (the factory + * runs {@link Map#copyOf} before constructing the impl); the constructor + * stores it by reference. + */ +final class AuditEventImpl implements AuditEvent { + + private final String domain; + private final String type; + private final long timestamp; + private final Map<String, Object> payload; + + AuditEventImpl(@NotNull String domain, + @NotNull String type, + long timestamp, Review Comment: same comment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
