rishabhdaim commented on PR #3064:
URL: https://github.com/apache/jackrabbit-oak/pull/3064#issuecomment-5188665400

   ## Review
   
   **P2** · `oak-doc/src/site/markdown/testing.md:68` · Testing doc's 
PostgreSQL Docker example still used `postgres:13-alpine`, below the new 
minimum.
   
   `RDBDocumentStoreDB.POSTGRES.checkVersion` now requires PostgreSQL >= 14.0 
(this PR). A developer following the doc's Docker command to stand up a local 
test database would pull `postgres:13-alpine`, below the new minimum, and hit 
the unsupported-version diagnostic at connection time.
   
   Fixed in c6f80699: bumped the Docker image tag/prose to 
`postgres:14-alpine`, and added `RDBJDBCToolsTest` covering 
`RDBJDBCTools.versionCheck` and `RDBDocumentStoreDB.POSTGRES.checkVersion` 
(including a regression guard for the 13→14 threshold, which had no prior test 
coverage).
   
   No correctness issues found in the version-check change itself — it only 
builds a logged diagnostic string and never throws or blocks the connection.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to