dulvac commented on PR #3059: URL: https://github.com/apache/jackrabbit-oak/pull/3059#issuecomment-5205853105
Second round is in. - `AuditEventImpl` moved to `spi.audit.impl`, which is not exported. - `AuditEvents` renamed to `AuditDispatch`. - `AuditBuffer.peek` and `drain` return empty lists instead of null. - `SessionBuffer` uses the default ArrayList capacity. - The "defensive copy" wording is fixed, though to shallow rather than deep. Details in the thread. `AuditDomain` and `AuditType` went in earlier, in c955987672. Two things I still need from you. Whether you want `Instant` instead of `long` on `getTimestamp()`, since that one changes an exported signature. And `AuditDispatch` is my name choice, not yours, so say if you'd rather have something else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
