bhabegger commented on code in PR #3068:
URL: https://github.com/apache/jackrabbit-oak/pull/3068#discussion_r3734583501


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/diff/DiffIndexMerger.java:
##########
@@ -424,7 +490,10 @@ public boolean processMerge(String indexName, JsonObject 
indexDiff, JsonObject n
         } else {
             String latestMergeChecksum = 
JsonNodeUpdater.oakStringValue(latestIndexVersion, "mergeChecksum");
             JsonObject latestDef = 
cleanedAndNormalized(switchToLuceneIfNeeded(latestIndexVersion));
-            if (isSameIgnorePropertyOrder(mergedDef, latestDef)) {
+            if (latestMergeChecksum == null && latestCustomized != null) {
+                log("mergeChecksum is missing in the old customized version, 
so this is a migration: {}", indexName);
+                // continue

Review Comment:
   Any reason to keep the commented `// continue` ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to