ChlineSaurus commented on code in PR #3084:
URL: https://github.com/apache/jackrabbit-oak/pull/3084#discussion_r3796766460
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/query/xpath/XPathToSQL2Converter.java:
##########
@@ -1006,6 +1007,9 @@ private void initialize(String query) throws
ParseException {
} else {
if (Character.isJavaIdentifierPart(c)) {
type = CHAR_NAME;
+ } else if ((settings == null ||
settings.isXmlNameCharsInPathEnabled()) && XMLChar.isName(c)) {
Review Comment:
I was not sure about this. I also had in mind that we decided that we want
to keep the old behavior as the default behavior for Oak changes, but in the
Agents.md we write that in case something is a bug fix, default should be on,
and only new features should be default off.
Further, it's not a very risky change, therefore I went with default
enabled, but if we want to be more defensive I can change it. 😌
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
