djscherrer commented on PR #3124: URL: https://github.com/apache/jackrabbit-oak/pull/3124#issuecomment-5713864182
With needsScores = !legacySortEnabled() && requiresScores(sort), the toggle in legacy mode forces needsScores = false, so the call is search(query, null, n, sort, false, false). In Lucene 4.7.2 the old search(query, n, sort) already delegates to exactly that (wrapFilter(query, null) == query, doDocScores/doMaxScore = false), so the legacy path is byte-for-byte the old behavior — no separate if needed. The two only diverge when needsScores == true (a jcr:score sort field is present), where doDocScores=true is what computes the scores. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
