rishabhdaim commented on code in PR #3227:
URL: https://github.com/apache/jackrabbit-oak/pull/3227#discussion_r4357122539


##########
oak-run/src/main/java/org/apache/jackrabbit/oak/run/RevisionsCommand.java:
##########
@@ -362,9 +374,11 @@ public void execute(String... args) throws Exception {
                 if (entireRepo) {
                     collect(options, closer, true);
                 } else if (isNotEmpty(path)) {
-                    collectDocument(options, closer, path);
+                    collectDocuments(options, closer, 
Collections.singletonList(path));
+                } else if (isNotEmpty(options.getPathsFile())) {
+                    collectDocuments(options, closer, 
readPaths(options.getPathsFile()));

Review Comment:
   Nitpick: if we have both a path and a file, the path would be picked, and 
the file would be silently ignored.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to