rishabhdaim commented on code in PR #3286:
URL: https://github.com/apache/jackrabbit-oak/pull/3286#discussion_r4546618355


##########
oak-doc/src/site/markdown/security/user/default.md:
##########
@@ -277,6 +277,38 @@ detail in section [Caching Results of Principal 
Resolution](../principal/cache.h
 It is not related to user management s.str. but affects the implementation
 specific `PrincipalProvider` implementation exposed by 
`UserConfiguration.getUserPrincipalProvider`.
 
+<a name="monitoring"></a>
+### Monitoring
+
+The default implementation exposes the following metrics through the 
`StatisticsProvider`:
+
+| Name                                          | Type  | Description |
+|-----------------------------------------------|-------|-------------|
+| `security.user.add_members.succeeded`         | Meter | Number of members 
successfully added to groups |
+| `security.user.add_members.failed`            | Meter | Number of members 
that failed to be added to groups |
+| `security.user.add_members.timer`             | Timer | Time spent adding 
members to groups |
+| `security.user.remove_members.succeeded`      | Meter | Number of members 
successfully removed from groups |
+| `security.user.remove_members.failed`         | Meter | Number of members 
that failed to be removed from groups |
+| `security.user.remove_members.timer`          | Timer | Time spent removing 
members from groups |
+| `security.user.get_members.timer`             | Timer | Time spent 
retrieving the members of a group |
+| `security.user.get_declared_members.timer`    | Timer | Time spent 
retrieving the declared members of a group |

Review Comment:
   **P3 · documentation:** These two descriptions are reversed relative to the 
current implementation: `doneGetMembers(..., true)` updates `get_members.timer` 
for declared-only retrieval, while `false` updates `get_declared_members.timer` 
for declared and inherited retrieval.
   
   **🛠️ Fix:** Describe the current routing here; changing the pre-existing 
implementation can be handled separately.
   
   _AI-generated review by GitHub Copilot. Human review is required; this does 
not approve the PR or replace existing review requirements._



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to