reschke commented on code in PR #3288:
URL: https://github.com/apache/jackrabbit-oak/pull/3288#discussion_r4546745148
##########
oak-it-osgi/test-bundles.xml:
##########
@@ -29,6 +29,9 @@
<scope>test</scope>
<includes>
<include>org.apache.jackrabbit:oak-blob-cloud</include>
+ <include>org.apache.jackrabbit:jackrabbit-data</include>
Review Comment:
This can go.
##########
oak-it-osgi/pom.xml:
##########
@@ -101,6 +101,18 @@
</build>
<dependencies>
+ <dependency>
Review Comment:
There is no dependency on jackrabbit-data (anymore).
##########
oak-it-osgi/src/test/java/org/apache/jackrabbit/oak/osgi/OSGiIT.java:
##########
@@ -236,61 +239,59 @@ public void slf4jImportRanges() throws
InvalidSyntaxException, ClassNotFoundExce
* Checks the embedded AWS SDK's logging requirements against SLF4J alone,
without Pax Logging exports.
*/
@Test
Review Comment:
We have several hundred lines of test code here. Do we **really** need this
here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]