tihom88 commented on PR #3271: URL: https://github.com/apache/jackrabbit-oak/pull/3271#issuecomment-6850722587
Thanks @fabriziofortino and @reschke for the review! 1. Moved the feature toggle to `org.apache.jackrabbit.oak.plugins.index.lucene.internal.LuceneFeatureToggles` (not in `Export-Package`), following the pattern of `ElasticFeatureToggles`. 2. Regarding the time-bombed test: agreeing with @reschke and @thomasm, tracking under OAK-12233 makes sense so tests don't break at inconvenient times. 3. Regarding `ElasticIndexProviderService`: yes, will follow up with a separate PR for Elastic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
