[ 
https://issues.apache.org/jira/browse/OAK-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13483151#comment-13483151
 ] 

Alex Parvulescu commented on OAK-368:
-------------------------------------

> I'm not sure if it really makes sense to run all of the tests multiple times 
> however, specially the xpath test

It does make sense, because of the way the QueryEngine integrates results from 
the indexes.
AFAIU if an index provides more rows than expected (which is expected 
behavior), the QE doesn't mind as it will verify the conditions again on the 
result sets and filter out non-matching items BUT if an index provides less 
rows, that will affect the final query outcome.
If the above statement is correct (please feel free to clarify if it is not 
so), then it definitely makes sense to re-run all the query tests on each index 
impl we have.

> Reopening the issue for now so we don't forget it (no immediate action 
> required however).
I don't really follow. Wouldn't you better create a separate issue concerning 
the tests rather than reopening this issue without having a real reason to: "no 
immediate action required"?
                
> Unify all index definitions under oak:index
> -------------------------------------------
>
>                 Key: OAK-368
>                 URL: https://issues.apache.org/jira/browse/OAK-368
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>             Fix For: 0.6
>
>
> I'll go through the older index definitions and replace references to 
> "oak-index" with the new index name "oak:index".
> I'll also take the opportunity to refactor the query tests a bit, to leverage 
> the new indexes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to