[ https://issues.apache.org/jira/browse/OAK-1138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13810960#comment-13810960 ]
Tobias Bocanegra edited comment on OAK-1138 at 11/1/13 2:10 AM: ---------------------------------------------------------------- of course you're right. but I always do invocation-count profiling to detect such pitfalls, and compare the own-time vs the callee times. however, we definitely need to look at this again. what puzzles me most, is the difference between admin and non-admin performance. even with the cache, which does not read much from the content anymore, once it's full, the difference is still significant. so thinking about this again - I might be mistaken that the cache really contributes so much to the performance improvements. I have to measure again, and profile again. the tests I did was reading 10k items in a 120k item repository, with ACLs on every 10th node. with 1 thread this takes 600ms per test (and before the cache changes, 800ms). but again, there might have been other improvements in the meantime :-) was (Author: tripod): thinking about this again - I might be mistaken that the cache really contributes so much to the performance improvements. I have to measure again, and profile again. the tests I did was reading 10k items in a 120k item repository, with ACLs on every 10th node. with 1 thread this takes 600ms per test (and before the cache changes, 800ms). but again, there might have been other improvements in the meantime :-) > Implement global per principal permission entry cache > ----------------------------------------------------- > > Key: OAK-1138 > URL: https://issues.apache.org/jira/browse/OAK-1138 > Project: Jackrabbit Oak > Issue Type: Sub-task > Components: security > Affects Versions: 0.10 > Reporter: Tobias Bocanegra > Assignee: Tobias Bocanegra > Priority: Minor > > In order to speedup ACL evaluation, we need some sort of cache that can hold > the pre-computed access control permission entries. -- This message was sent by Atlassian JIRA (v6.1#6144)