[
https://issues.apache.org/jira/browse/OAK-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13899172#comment-13899172
]
Thomas Mueller commented on OAK-377:
------------------------------------
DbBlobStore.AbstractIterator also silently ignores all exceptions. The
@Override tag is missing for computeNext.
Code conventions: It should be "static final" not "final static". If you use
Eclipse or IntelliJ, please configure it to use Checkstyle. There are some
"static" fields that should be final (MarkSweepGarbageCollector.NEWLINE for
example). Some methods can be declared static, for example saveBatchToFile. The
field "boolean finished = false": please don't set it to false, because false
is the default (the same for "done"). BlobGarbageCollector.collectGarbage()
doesn't need to be marked as public because this is an interface.
deleteChunk: this should be a conditional delete: only if lastMod is still old.
Could you change the method to use the maxLastModifiedTime as well please? I
will still try to commit the patch, but this should be changed I think.
> Data store garbage collection
> -----------------------------
>
> Key: OAK-377
> URL: https://issues.apache.org/jira/browse/OAK-377
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: core, mk
> Reporter: Thomas Mueller
> Assignee: Thomas Mueller
> Fix For: 0.17
>
> Attachments: OAK-377.patch
>
>
> Unused binaries in the data store need to be garbage collected.
> There is a partial implementation in oak-mk, however it is currently not run
> (not run automatically, and I think there is no way to run it manually).
> Also, we might want to investigate in faster garbage collection algorithms:
> young generation garbage collection, or garbage collection using reference
> counting (for example using an index of references to the data store).
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
