[ 
https://issues.apache.org/jira/browse/OAK-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13925620#comment-13925620
 ] 

Thomas Mueller commented on OAK-1263:
-------------------------------------

Hi,

There are some formatting issues in the patch:

OrderedIndex: 
* missing spaces before "{".
* missing javadoc for return tag in the fromString method
* @Nullable @CheckForNull should be before public static according to Checkstyle
* Javadoc: Missing closing brace for inline tag for DIRECTION (wrong format) - 
see 
http://stackoverflow.com/questions/647195/how-do-you-escape-curly-braces-in-javadoc-inline-tags-such-as-the-code-tag

OrderedPropertyIndex: 
* no class level javadoc

OrderedPropertyIndexEditor: 
* no class level javadoc
* missing spaces after comma, (, {

OrderedContentMirrorStoreStrategy:
* formatting (as above)
* superfluous () for return and conditional statements

OrderedContentMirrorStorageStrategyTest:
* naming conventions


> optimize oak index to support 'fast ORDER BY' queries to support sorting & 
> pagination for large set of children
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: OAK-1263
>                 URL: https://issues.apache.org/jira/browse/OAK-1263
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>    Affects Versions: 0.12
>            Reporter: Stefan Egli
>            Assignee: Thomas Mueller
>             Fix For: 0.19
>
>         Attachments: OAK-1263-r1.patch, OAK-1263-r1a.patch, 
> OAK-1263-r1b.patch, OAK-1263-r1c.patch, OAK-1263-r1d.patch, 
> OAK-1263-r2.patch, OAK-1263-r3.patch, benchmark-20140228112150.log, 
> benchmark-20140228120718.log, benchmark-20140228125248.log
>
>
> We have a use case where we'd like to be able to use an index in a 
> "pagination-like" fashion. That is, we'd like to be able to have an index on 
> a subtree on a certain property, and then run a query which does ORDER BY 
> that property combined with OFFSET. That way, essentially allowing pagination 
> of child nodes of a particular parent based on 'sorted by a certain property'.
> AFAIU currently the oak index is not optimized to support ORDER BY queries in 
> a fast manner. The index keeps 'the child nodes unsorted', ie to process an 
> ORDER BY, the child nodes would have to be 'manually sorted' which can result 
> in bad performance given a large number of child nodes.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to