[ 
https://issues.apache.org/jira/browse/OAK-1561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13945110#comment-13945110
 ] 

Thomas Mueller commented on OAK-1561:
-------------------------------------

Again there is a problem applying the patch (there is a segment that doesn't 
match). 

Again I made some changes:

* field "private boolean firstReturned = false;" . "= false" is not needed, as 
it's the default.
* return (arg0 != null && searchfor.equals(arg0.getName()));: the surrounding 
() is not needed, because "return" is not a function call.
* again missing spaces for "if(arg0!=null){", and some missing spaces after a 
comma. Could you change your IDE settings please, or use Checkstyle to detect 
such problems if you don't use an IDE that can mark it?
* the tests queryBetweenIncludeHigher and queryBetweenIncludeBoth have 
System.out.println. We don't use that in tests.


> Implement optimised range queries
> ---------------------------------
>
>                 Key: OAK-1561
>                 URL: https://issues.apache.org/jira/browse/OAK-1561
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core
>            Reporter: Davide Giannella
>            Assignee: Thomas Mueller
>             Fix For: 0.20
>
>         Attachments: OAK-1561-r1.patch, OAK-1561-r2.patch, OAK-1561-r3.patch
>
>
> Add in OAK the ability to perform range queries on ordered indexes so that it 
> will be possible to return results for something like {{SELECT * FROM 
> [nt:base] WHERE lastModified > cast('2014-03-05T14:36:52.215Z' as date)}}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to