[ 
https://issues.apache.org/jira/browse/OAK-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13967877#comment-13967877
 ] 

Chetan Mehrotra commented on OAK-1722:
--------------------------------------

[~jukkaz] The approach looks pretty neat !!. I would prefer it over my proposed 
approach which relied on SearcherManager and had to workaround couple of its 
design limitations. It also avoid all the version check I had to implement due 
to NodeState not being comparable as Observer always see a linear sequence of 
events. 

+1 to the approach taken

[~alexparvulescu] Can you review the Jukka's patch. I am not sure how your 
intended support for multiple lucene indexes can be supported as it currently 
access root node for index definition.

Once you apply the patch I would modify it to support for lazy cursor (OAK-925) 
and also copying of lucene index files to local dir OAK-1724


> Use a shared IndexSearcher for performing Lucene queries
> --------------------------------------------------------
>
>                 Key: OAK-1722
>                 URL: https://issues.apache.org/jira/browse/OAK-1722
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: query
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.0, 1.1
>
>
> Currently the Lucene integrations opens a new IndexSeracher for every read 
> call. This proves to be costly as per OAK-1702. Instead we should use a 
> shared IndexSearcher based on approach taken in Lucene 
> [SearcherManager|https://lucene.apache.org/core/3_6_0/api/all/org/apache/lucene/search/SearcherManager.html].
> Further there needs to be a way to pickup any changes in Lucene index across 
> cluster nodes



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to