[ 
https://issues.apache.org/jira/browse/OAK-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14343205#comment-14343205
 ] 

Chetan Mehrotra commented on OAK-2499:
--------------------------------------

Patch looks fine. Minor nitpick

bq. The description is then registered as a property 
("oak.documentstore.description") to the DocumentNodeStoreService.

Instead of {{oak.documentstore.description}} would prefer 
{{oak.nodestore.description}}

bq. Should I register another property ("oak.blobstore.description") for the 
blobstore

That would be better. So if explicit {{FileDataStore}} or {{S3DataStore}} are 
configured they would be registered along with required description. For others 
it would be implied that the default are being used

For the description should we do it like key=value pair

* type=mongo,version=2.6,replica=true


> Expose mongo and db versions for reporting purposes
> ---------------------------------------------------
>
>                 Key: OAK-2499
>                 URL: https://issues.apache.org/jira/browse/OAK-2499
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: mongomk, rdbmk, segmentmk
>            Reporter: Marius Petria
>         Attachments: OAK-2499.1.diff
>
>
> For reporting purposes I need to find out from java the MK type and also
> for mongo version and the info about used DB make/version?
> [~chetanm] suggested that such information can be exposed "when we register a
> {{NodeStore}} instances within OSGi we can also add a service property
> which captures such implementation details. Possibly use
> service.description or define a new one which provide a comma separated
> list of attributes.”



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to