[ 
https://issues.apache.org/jira/browse/OAK-2603?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chetan Mehrotra resolved OAK-2603.
----------------------------------
    Resolution: Fixed

After looking further I realized that having a dedicated 
{{NodeDocumentIdComparator}} would be better and it would perform better for 
large list sorting so added a comparator and used that to sort in VersionGC in 
http://svn.apache.org/r1665835

> Failure in one of the batch in VersionGC might lead to orphaned nodes
> ---------------------------------------------------------------------
>
>                 Key: OAK-2603
>                 URL: https://issues.apache.org/jira/browse/OAK-2603
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: mongomk
>            Reporter: Chetan Mehrotra
>            Assignee: Chetan Mehrotra
>             Fix For: 1.1.8, 1.0.13
>
>         Attachments: OAK-2603.patch
>
>
> VersionGC logic currently performs deletion of nodes in batches. For GC to 
> work properly NodeDocument should always be removed in bottom-up mode i.e. 
> parent node should be removed *after* child has been removed
> Currently the GC logic deletes the NodeDocument in undefined order. In such 
> mode if one of the batch fails then its possible that parent might have got 
> deleted but the child was not deleted. 
> Now in next run the child node would not be recognized as a deleted node 
> because the commit root would not be found.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to