[ https://issues.apache.org/jira/browse/OAK-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14356751#comment-14356751 ]
Chetan Mehrotra edited comment on OAK-2557 at 3/11/15 11:38 AM: ---------------------------------------------------------------- [patch2|^OAK-2557-2.patch] which uses {{ExternalSort}} to sort the DocumentId. It uses in memory approach for upto 100k ids. If more than that limit are to be deleted then it switches to {{ExternalSort}} [~egli] [~mreutegg] Can you have a look [~amitjain] Can you review the usage of ExternalSort as this was also used in Blob GC. So your feedback would be helpful! was (Author: chetanm): [patch2|^OAK-2557-2.patch] which uses {{ExternalSort}} to sort the DocumentId [~egli] [~mreutegg] Can you have a look [~amitjain] Can you review the usage of ExternalSort as this was also used in Blob GC. So your feedback would be helpful! > VersionGC uses way too much memory if there is a large pile of garbage > ---------------------------------------------------------------------- > > Key: OAK-2557 > URL: https://issues.apache.org/jira/browse/OAK-2557 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, mongomk > Affects Versions: 1.0.11 > Reporter: Stefan Egli > Assignee: Chetan Mehrotra > Priority: Blocker > Fix For: 1.0.13, 1.2 > > Attachments: OAK-2557-2.patch, OAK-2557.patch > > > It has been noticed that on a system where revision-gc > (VersionGarbageCollector of mongomk) did not run for a few days (due to not > interfering with some tests/large bulk operations) that there was such a > large pile of garbage accumulating, that the following code > {code} > VersionGarbageCollector.collectDeletedDocuments > {code} > in the for loop, creates such a large list of NodeDocuments to delete > (docIdsToDelete) that it uses up too much memory, causing the JVM's GC to > constantly spin in Full-GCs. -- This message was sent by Atlassian JIRA (v6.3.4#6332)