[
https://issues.apache.org/jira/browse/OAK-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14358632#comment-14358632
]
Thomas Mueller commented on OAK-2557:
-------------------------------------
I assume the document ids can not contain strange characters (newlines), right?
I noticed with debug level logging, the removed entries are logged, but only up
to 1000. Maybe it's better to log in all cases? The list is iterated over twice
in this case (for logging and for removing), but the logic looks good to me.
> VersionGC uses way too much memory if there is a large pile of garbage
> ----------------------------------------------------------------------
>
> Key: OAK-2557
> URL: https://issues.apache.org/jira/browse/OAK-2557
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: core, mongomk
> Affects Versions: 1.0.11
> Reporter: Stefan Egli
> Assignee: Chetan Mehrotra
> Priority: Blocker
> Fix For: 1.0.13, 1.2
>
> Attachments: OAK-2557-2.patch, OAK-2557-3.patch, OAK-2557.patch
>
>
> It has been noticed that on a system where revision-gc
> (VersionGarbageCollector of mongomk) did not run for a few days (due to not
> interfering with some tests/large bulk operations) that there was such a
> large pile of garbage accumulating, that the following code
> {code}
> VersionGarbageCollector.collectDeletedDocuments
> {code}
> in the for loop, creates such a large list of NodeDocuments to delete
> (docIdsToDelete) that it uses up too much memory, causing the JVM's GC to
> constantly spin in Full-GCs.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
