[
https://issues.apache.org/jira/browse/OAK-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14482703#comment-14482703
]
Thomas Mueller commented on OAK-2720:
-------------------------------------
The patch looks good to me. The risk is very low, so I'm OK to include it for
Oak 1.2.
> of more than 10000 (default).
Yes, it's true. I thought the warning is at 1'000, but you are right, it's at
10'000 (see the patch).
> even if end result set is small say 100 but indexed paths are deep
Are you sure? If the limit is at 10'000, then with 100 entries the paths would
need to be extremely deep (100 on average, per node).
> Misleading traversal warning message while performing query
> -----------------------------------------------------------
>
> Key: OAK-2720
> URL: https://issues.apache.org/jira/browse/OAK-2720
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
> Reporter: Chetan Mehrotra
> Fix For: 1.2
>
> Attachments: OAK-2720.patch
>
>
> Currently {{ContentMirrorStoreStrategy}} logs a traversal warning if the
> property index performs node traversal of more than 10000 (default).
> The intention here being to warn the end user that traversing so many nodes
> would cause performance issue. Traversal in itself might happen due to many
> reason like
> # Query not using right index. If the query has two property restriction and
> one of them is more broad while other is more selective and index is defined
> only for first then more traversal would be performed. The warning should
> help the user to create a new index for second property
> # Caller is fetching way more result - Query might end with say 50k result
> and caller is reading all. Such warning would help user to probably go for
> pagination
> So above are valid cases. However currently warning is also seen even if end
> result set is small say 100 but indexed paths are deep. As
> {{ContentMirrorStoreStrategy}} mirrors the path structure the current
> counting logic also counts the intermediate traversals. This warning is then
> misleading as how this internal structure is created is an implementation
> details of index which end user does not have any control. This leaves
> following options
> # Use different storage strategy which is more efficient in storage
> # Do not count the intermediate nodes traversed within index path and instead
> only count the matching node
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
