[ 
https://issues.apache.org/jira/browse/OAK-3002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589684#comment-14589684
 ] 

Chetan Mehrotra commented on OAK-3002:
--------------------------------------

bq. the journal contains a tree of nodes that have changed. However, it does 
not yet indicate if a non-leaf node has changed or not. For a leaf-node it is 
clear, that has changed. But for a non-leaf that is atm not yet marked in any 
way (maybe we could do that).

Aah was not aware of that. I thought we are storing list of changed paths, now 
I see that its a JSOPIt would be better if we do this and thus avoid the 
complexity in cache invalidation logic

[~mreutegg] thoughts?

> Optimize docCache and docChildrenCache invalidation by filtering using journal
> ------------------------------------------------------------------------------
>
>                 Key: OAK-3002
>                 URL: https://issues.apache.org/jira/browse/OAK-3002
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core, mongomk
>            Reporter: Stefan Egli
>            Assignee: Stefan Egli
>              Labels: scalability
>             Fix For: 1.3.1, 1.2.3
>
>         Attachments: 
> OAK-3002-improved-doc-and-docChildren-cache-invaliation.3.patch, 
> OAK-3002-improved-doc-cache-invaliation.2.patch
>
>
> This subtask is about spawning out a 
> [comment|https://issues.apache.org/jira/browse/OAK-2829?focusedCommentId=14588114&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14588114]
>  on OAK-2829 re optimizing docCache invalidation using the newly introduced 
> external diff journal:
> {quote}
> Attached OAK-2829-improved-doc-cache-invaliation.patch which is a suggestion 
> on how to avoid invalidating the entire document cache when doing a 
> {{backgroundRead}} but instead making use of the new journal: ie only 
> invalidate from the document cache what has actually changed.
> I'd like to get an opinion ([~mreutegg], [~chetanm]?) on this first, I have a 
> load test pending locally which found invalidation of the document cache to 
> be the slowest part thus wanted to optimize this first.
> Open still/next:
>  * also invalidate only necessary parts from the docChildrenCache
>  * junits for all of these
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to