[ https://issues.apache.org/jira/browse/OAK-2829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14589848#comment-14589848 ]
Stefan Egli commented on OAK-2829: ---------------------------------- [~mreutegg], yes, looks more OO-like and even though {{isParent}} was originally meant to be 'isDirectParent', the new implementation is actually correct as the previous one was generating half-finished entries into the diffCache because of this (they did get updated later in the loop, but nevertheless, temporarily it put half-finished entries in). So: +1 > Comparing node states for external changes is too slow > ------------------------------------------------------ > > Key: OAK-2829 > URL: https://issues.apache.org/jira/browse/OAK-2829 > Project: Jackrabbit Oak > Issue Type: Bug > Components: core, mongomk > Reporter: Marcel Reutegger > Assignee: Marcel Reutegger > Priority: Blocker > Labels: scalability > Fix For: 1.3.1, 1.2.3 > > Attachments: CompareAgainstBaseStateTest.java, > OAK-2829-JournalEntry.patch, OAK-2829-gc-bug.patch, > OAK-2829-improved-doc-cache-invaliation.2.patch, > OAK-2829-improved-doc-cache-invaliation.patch, graph-1.png, graph.png > > > Comparing node states for local changes has been improved already with > OAK-2669. But in a clustered setup generating events for external changes > cannot make use of the introduced cache and is therefore slower. This can > result in a growing observation queue, eventually reaching the configured > limit. See also OAK-2683. -- This message was sent by Atlassian JIRA (v6.3.4#6332)