[ 
https://issues.apache.org/jira/browse/OAK-3076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14616329#comment-14616329
 ] 

Michael Dürig commented on OAK-3076:
------------------------------------

Patch looks good AFICS apart from an issue with the null check in private 
constructor of {{CompactDiff}}: the patch in the if clause should refer to the 
passed argument, not to the instance field. Also I'm not sure about the '@' 
notation for the logged property events. But that's a matter of taste though. 

> Compaction should trace log the current processed path
> ------------------------------------------------------
>
>                 Key: OAK-3076
>                 URL: https://issues.apache.org/jira/browse/OAK-3076
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>              Labels: gc
>             Fix For: 1.2.3, 1.3.3
>
>         Attachments: OAK-3076.patch
>
>
> A lot of SegmentNotFoundExceptions happen during compaction (offline or 
> online) and these are repeatable exceptions. I would like to add a 'trace' 
> log to make it easy to follow up on the progress and get an indication of 
> where the SNFE is happening, without relying on offline intervention (via 
> oak-run).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to