[ 
https://issues.apache.org/jira/browse/OAK-3104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Vikas Saurabh updated OAK-3104:
-------------------------------
    Attachment: 0002-OAK-3104-update-DocumentNodeStoreTest.rollback-to-as.patch
                0001-OAK-3104-rollback-of-new-documents-should-mark-_dele.patch

Attaching 
[^0001*.patch|0001-OAK-3104-rollback-of-new-documents-should-mark-_dele.patch] 
which update {{UpdateOp.getReverseOperation}} to set {{_deletedOnce}} if 
original operation had {{isNew}} set.

[^0002*.patch|0002-OAK-3104-update-DocumentNodeStoreTest.rollback-to-as.patch] 
is about updating {{DocumentNodeStoreTest.rollback}} to assert {{_deletedOnce}} 
is set correctly.

[~mreutegg], can you please review these?

> Version garbage collector doesn't collect a rolled back document if it was 
> never deleted
> ----------------------------------------------------------------------------------------
>
>                 Key: OAK-3104
>                 URL: https://issues.apache.org/jira/browse/OAK-3104
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: mongomk
>            Reporter: Vikas Saurabh
>            Priority: Minor
>         Attachments: 
> 0001-OAK-3104-rollback-of-new-documents-should-mark-_dele.patch, 
> 0002-OAK-3104-update-DocumentNodeStoreTest.rollback-to-as.patch
>
>
> If a commit gets rolled back it can leave (in case the document was never 
> deleted explicitly) a document in a state like:
> {noformat}
> {
>        "_id" : "7:/etc/workflow/packages/2014/10/12/rep:ours",
>        "_deleted" : {
>        },
>        "_commitRoot" : {
>        },
>        "jcr:primaryType" : {
>        },
>        "_modified" : NumberLong(1413126245),
>        "_children" : true,
>        "_modCount" : NumberLong(2)
> }
> {noformat}
> If the path is fairly busy, the document can get created naturally later and 
> then follow the usual cycle. But, at times, such documents are ephemeral in 
> nature and never re-used. In those cases, such documents can remain silently 
> without getting collected.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to