Chetan Mehrotra created OAK-3146:
------------------------------------
Summary: ExternalLoginModuleFactory should inject SyncManager and
ExternalIdentityProviderManager
Key: OAK-3146
URL: https://issues.apache.org/jira/browse/OAK-3146
Project: Jackrabbit Oak
Issue Type: Improvement
Components: security
Reporter: Chetan Mehrotra
Priority: Minor
Fix For: 1.2.4, 1.3.4, 1.0.18
{{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and
{{ExternalIdentityProviderManager}} in initialize call which performs service
lookup using ServiceTracker. Doing a service lookup in critical path would have
adverse performance impact.
Instead of performing the lookup {{ExternalLoginModuleFactory}} should track
the two manager instances and pass them to {{ExternalLoginModule}}. This would
ensure that expensive operation like service lookup is not performed in
critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
