[
https://issues.apache.org/jira/browse/OAK-3146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
angela reopened OAK-3146:
-------------------------
[~chetanm], you filed this issue with the label 'performance' but fixed the
issue without even verifying i.e. writing a benchmark test that would prove
that you actually found/fixed a performance issue. instead you ask the adobe
internal reporter (i.e. the client) to verify that you actually fixed the
performance issue reported.
that's not how i want changes to be made in the security area. IMHO is the duty
of the developer to test the changes and verify that it actually solves the
reported problem. in case of a performance issue this should be covered with
benchmarks, such that we reproduce the issue first and _then_ fix it and in
addition verify later on, that the fix doesn't get broken later on. just having
oral confirmation from a customer without the ability to automatically verify
it is not acceptable.
further more: you files this issue as "Improvement": our policy is that we
don't back port improvements unless there is a _very_ strong reason to do so
(e.g. an adobe internal hotfix request). there is not auto-backport for
improvements and i want you to revert that.
> ExternalLoginModuleFactory should inject SyncManager and
> ExternalIdentityProviderManager
> ----------------------------------------------------------------------------------------
>
> Key: OAK-3146
> URL: https://issues.apache.org/jira/browse/OAK-3146
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: security
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Priority: Minor
> Labels: performance
> Fix For: 1.2.4, 1.3.4, 1.0.18
>
> Attachments: OAK-3146.patch
>
>
> {{ExternalLoginModule}} currently performs a lookup of {{SyncManager}} and
> {{ExternalIdentityProviderManager}} in initialize call which performs service
> lookup using ServiceTracker. Doing a service lookup in critical path would
> have adverse performance impact.
> Instead of performing the lookup {{ExternalLoginModuleFactory}} should track
> the two manager instances and pass them to {{ExternalLoginModule}}. This
> would ensure that expensive operation like service lookup is not performed in
> critical path
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
