[
https://issues.apache.org/jira/browse/OAK-3155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14645741#comment-14645741
]
Alex Parvulescu commented on OAK-3155:
--------------------------------------
looks good!
the only issue I see is around the '//Do not update the status as technically
the run is not complete' behavior. What will happen is the #start method will
get called again on the next run, so the watch will reset making the intention
to keep the stats running superfluous. I think we should call
#postAsyncRunStatsStatus anyway, even if it's a failed run, I wouldn't mix
error handling with stats.
> AsyncIndex stats do not capture execution for runs where no indexing is
> performed
> ---------------------------------------------------------------------------------
>
> Key: OAK-3155
> URL: https://issues.apache.org/jira/browse/OAK-3155
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: query
> Reporter: Chetan Mehrotra
> Assignee: Chetan Mehrotra
> Priority: Minor
> Fix For: 1.3.4
>
> Attachments: OAK-3155.patch
>
>
> {{AsyncIndexStats}} currently provides a time series of the stats around when
> async indexing run and what time it took. Current logic only collect stats
> when actual indexing is performed. If no change happened in the repository
> from the last run that stats around that is ignored.
> Due to this if we see a time series of when runs happen then it might not be
> true and gives a false impression that async indexing is slow.
> As a fix we should record execution stats for every run
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
