[ 
https://issues.apache.org/jira/browse/OAK-3371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14740249#comment-14740249
 ] 

Thomas Mueller commented on OAK-3371:
-------------------------------------

Generally, it looks good, I like the approach. There are a few minor things I 
would like to change: I don't like the "instanceof" check there. I think it's 
possible to avoid it, or move it to the "simplify" method. The method name 
"restrictPropertyOnFilter": it seems to be unnecessary, as the same can be done 
using "enforcePropertyExistence".

I will try to work on the patch and upload a new one.

> Wrong evaluation of NOT clause
> ------------------------------
>
>                 Key: OAK-3371
>                 URL: https://issues.apache.org/jira/browse/OAK-3371
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: query
>    Affects Versions: 1.2.4, 1.3.5
>            Reporter: Davide Giannella
>            Assignee: Davide Giannella
>             Fix For: 1.3.6
>
>         Attachments: OAK-3371-2.patch, OAK-3371-test.diff, OAK-3371.patch
>
>
> When executing a query like 
> {noformat}
> SELECT * FROM [nt:unstructured] WHERE ISDESCENDANTNODE([/test]) AND NOT 
> CONTAINS(foo, 'bar')
> {noformat}
> and the {{nodeType}} index plays the not clause is not applied properly. 
> Nodes **with** the property are returned as well.
> [test|^OAK-3371-test.diff] showing the bug.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to