[
https://issues.apache.org/jira/browse/OAK-3523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961320#comment-14961320
]
Tobias Bocanegra commented on OAK-3523:
---------------------------------------
I disagree with the patch. it is less performant...i'll have a closer look
again....
> DefaultSyncContext catches ClassCastException
> ---------------------------------------------
>
> Key: OAK-3523
> URL: https://issues.apache.org/jira/browse/OAK-3523
> Project: Jackrabbit Oak
> Issue Type: Bug
> Components: auth-external
> Reporter: angela
> Assignee: angela
> Labels: technical_debt
> Attachments: OAK-3523.patch, OAK-3523_3.patch, OAK-3523_test.patch
>
>
> the group and group-member sync code in the {{DefaultSyncContext}} twice
> catches {{ClassCastException}} and swallows exception situations, where a
> user is found, when actually a {{Group}} was expected.
> i would suggest to
> - explicitly test the assumption wrt {{ExternalIdentity}} being a group
> (instead of waiting for the exception)
> - make use of {{UserManager.getAuthorizable(String, Class) to explicitly
> retrieve a Group with a given ID, when this is actually expected. This method
> will throws an {{AuthorizableTypeException}} if there exists a {{User}} with
> that ID as thus properly raise the unexpected behavior instead of swallowing
> with a log-warning.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
