[ https://issues.apache.org/jira/browse/OAK-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15029050#comment-15029050 ]
Julian Reschke commented on OAK-3649: ------------------------------------- While working on OAK-3659 I realized that RDB and Mongo currently differ in how "applyChanges" is used. In RDB, it's a wrapper around UpdateUtils which also handles the MODCOUNT increment (plus the RDB-related CMODCOUNT). Also, it checks conditions. In MongoDocumentStore, updating MODCOUNT is a side effect of {{DBObject createUpdate(UpdateOp}} which is a bit obscure (it's not clear from the call that the {{UpdateOp}} indeed is modified. We probably should refactor this as well. > Extract node document cache from Mongo and RDB document stores > -------------------------------------------------------------- > > Key: OAK-3649 > URL: https://issues.apache.org/jira/browse/OAK-3649 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk, mongomk, rdbmk > Reporter: Tomek Rękawek > Priority: Minor > Labels: candidate_oak_1_0, candidate_oak_1_2 > Fix For: 1.3.12 > > > MongoDocumentStore and RDBDocumentStore contains copy & pasted methods > responsible for handling node document cache. Extract these into a new > NodeDocumentCache. -- This message was sent by Atlassian JIRA (v6.3.4#6332)