[ 
https://issues.apache.org/jira/browse/OAK-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15094122#comment-15094122
 ] 

Alex Parvulescu commented on OAK-3868:
--------------------------------------

looks ok, one further refactoring step is to call the new method in the 
SegmentTracker constructor itself.

[0] 
https://github.com/mduerig/jackrabbit-oak/blob/942be4d0ba227fad3965ac8b849ca56e0211aed3/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/segment/SegmentTracker.java#L129

> Move createSegmentWriter() from FileStore to SegmentTracker
> -----------------------------------------------------------
>
>                 Key: OAK-3868
>                 URL: https://issues.apache.org/jira/browse/OAK-3868
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>              Labels: technical_debt
>
> I think it makes sense to move said method. This simplifies the code in 
> various places as it somewhat decouples the concern "writing segments" from 
> an implementation ({{FileStore}}). 
> Also this is somewhat a prerequisite for my current work on OAK-3348.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to