[ https://issues.apache.org/jira/browse/OAK-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096135#comment-15096135 ]
Alex Parvulescu commented on OAK-3862: -------------------------------------- I agree that the second proposal (extra oak module) looks easier to achieve, I initially found the ServiceLoader approach interesting, but the overhead seems too high (too few tests to justify doing this, no way to automatically pull in all tests tagged with a category, 'fail-at-end' option seems risky). also, it is worth reevaluating the proposed name 'oak-it' seeing as it will only include one IT test out of 16 :) > Move integration tests in a different Maven module > -------------------------------------------------- > > Key: OAK-3862 > URL: https://issues.apache.org/jira/browse/OAK-3862 > Project: Jackrabbit Oak > Issue Type: Improvement > Reporter: Francesco Mari > Assignee: Francesco Mari > Fix For: 1.4 > > > While moving the Segment Store and related packages into its own bundle, I > figured out that integration tests contained in {{oak-core}} contribute to a > cyclic dependency between the (new) {{oak-segment}} bundle and {{oak-core}}. > The dependency is due to the usage of {{NodeStoreFixture}} to instantiate > different implementations of {{NodeStore}} in a semi-transparent way. > Tests depending on {{NodeStoreFixture}} are most likely integration tests. A > clean solution to this problem would be to move those integration tests into > a new Maven module, referencing the API and implementation modules as needed. -- This message was sent by Atlassian JIRA (v6.3.4#6332)