[ 
https://issues.apache.org/jira/browse/OAK-3724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15121683#comment-15121683
 ] 

Marcel Reutegger commented on OAK-3724:
---------------------------------------

But the signature is nearly the same, except for the return type. I think we 
could simplify the applyToDocumentStore() method quite a bit if we replace 
create() with createOrUpdate(). There wouldn't be any need for the logic which 
check whether the create was successful or not.

> Use the bulk createOrUpdate in Commit
> -------------------------------------
>
>                 Key: OAK-3724
>                 URL: https://issues.apache.org/jira/browse/OAK-3724
>             Project: Jackrabbit Oak
>          Issue Type: Technical task
>          Components: documentmk
>            Reporter: Tomek Rękawek
>            Assignee: Marcel Reutegger
>            Priority: Blocker
>             Fix For: 1.4, 1.3.15
>
>         Attachments: OAK-3724-1.patch, OAK-3724.patch, deadlock.txt
>
>
> The {{DocumentStore#createOrUpdate(Collection, UpdateOp)}} method is invoked 
> in a loop in the {{Commit#applyToDocumentStore()}}, once for each changed 
> node. Replace it with the bulk version created in OAK-3662.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to