[ https://issues.apache.org/jira/browse/OAK-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123351#comment-15123351 ]
Chetan Mehrotra commented on OAK-3952: -------------------------------------- Had a chat with [~mduerig]. It would be a risky change for 1.4. However its something which we should address and probably allow for the current quesu to finish off. So would get back on this for 1.6 > BackgroundObserver close should wait for stop to be processed > ------------------------------------------------------------- > > Key: OAK-3952 > URL: https://issues.apache.org/jira/browse/OAK-3952 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: core > Reporter: Chetan Mehrotra > Assignee: Chetan Mehrotra > Priority: Minor > Fix For: 1.6 > > Attachments: OAK-3952-v1.patch > > > {{BackgroundObserver}} close method currently says that it does not wait for > thread to finish. This can lead to situation when during shutdown the backing > {{NodeStore}} goes away while the background thread is still busy with diff > and that would lead to exceptions in the log. > As being done in OAK-3923 the close call should wait for {{STOP}} signal to > be processed before returning from close call. > On side note we should also provide an option where the close call should > wait for the queue to be processed instead of just silently clearing the > queue which can lead to potential loss of important local events. Note that > can happen for proper ordered shutdown! -- This message was sent by Atlassian JIRA (v6.3.4#6332)