[ 
https://issues.apache.org/jira/browse/OAK-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15123764#comment-15123764
 ] 

Michael Dürig commented on OAK-3958:
------------------------------------

Patch looks good. 

What is the reason for changing the load factor of the linked hash map from 
0.75 to 0.9? According to the Javadoc of {{HashMap}}: "As a general rule, the 
default load factor (.75) offers a good tradeoff between time and space costs".



> Split SegmentWriter records cache into 2: strings and templates
> ---------------------------------------------------------------
>
>                 Key: OAK-3958
>                 URL: https://issues.apache.org/jira/browse/OAK-3958
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: segmentmk
>            Reporter: Alex Parvulescu
>            Assignee: Alex Parvulescu
>            Priority: Minor
>             Fix For: 1.3.15
>
>         Attachments: OAK-3958.patch
>
>
> I think it makes sense to split the 2 caches apart, from what I've seen the 
> ratio is very unbalanced (10 strings to 1 template), so keeping the 2 
> together might hurt the template cache.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to