[ https://issues.apache.org/jira/browse/OAK-4167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vikas Saurabh updated OAK-4167: ------------------------------- Description: Here's a list of improvements done for lucene based suggestions that were done for 1.4: # OAK-2754: Use non unique PathCursor in LucenePropertyIndex (*b) (/) ([trunk@1682488|https://svn.apache.org/r1682488], [1.2@1738061|https://svn.apache.org/r1738061]) # OAK-3230: Query engine should support virtual index rows (*y) (/) ([trunk@1697896|https://svn.apache.org/r1697896], [1.2@1738062|https://svn.apache.org/r1738062]) # OAK-3156: Allows suggestions to work on non-nt:base (*y) (/) ([trunk@1708307|https://svn.apache.org/r1708307], [1.2@1738063|https://svn.apache.org/r1738063]) # OAK-3509: Returns suggesion result per row (while this isn't really required, but it'd make other backports rather simple) (*y) (/) ([trunk@1715716|https://svn.apache.org/r1715716], [1.2@1738066|https://svn.apache.org/r1738066]) # OAK-3149: Uses one suggest dictionary per index definition. Useful when there are multiple indices supporting suggestions (*y) (/) ([trunk@1716100|https://svn.apache.org/r1716100], [1.2@1738068|https://svn.apache.org/r1738068]) # OAK-3407: Allows to have single work suggestions instead of phrases (*y) (/) ([trunk@1716588|https://svn.apache.org/r1716588], [trunk@1716589|https://svn.apache.org/r1716589], [trunk@1717203|https://svn.apache.org/r1717203], [1.2@1738069|https://svn.apache.org/r1738069]) # OAK-3692: java.lang.NoClassDefFoundError: org/apache/lucene/index/sorter/Sorter$DocComparator (*y) (/) ([trunk@1717410|https://svn.apache.org/r1717410], [1.2@1738070|https://svn.apache.org/r1738070]) # OAK-3838: Fixes issues of picking up a competing-non-suggest-capable index incorrectly to provide suggestions (*y) (/) ([trunk@1723565|https://svn.apache.org/r1723565], [1.2@1738073|https://svn.apache.org/r1738073]) # OAK-3825: Including Resource name to suggestions (*y) (/) ([trunk@1725941|https://svn.apache.org/r1725941], [1.2@1738074|https://svn.apache.org/r1738074]) # OAK-2477: Namespaced global configs for suggestions (*y) (/) ([trunk@1726237|https://svn.apache.org/r1726237], [1.2@1738075|https://svn.apache.org/r1738075]) # OAK-3994: Simple query on suggestion/spellcheck with unambiguous index def and one descendant clause should work (*y) (x) ([trunk@1729505|https://svn.apache.org/r1729505], [trunk@1729599|https://svn.apache.org/r1729599]) # OAK-4009: Search done via Lucene index might return duplicate results (*b) (x) ([trunk@1729957|https://svn.apache.org/r1729957]) # OAK-4070: Refactor LuceneIndexEditorContext to allow for switchable clock for testing (*b) (x) ([trunk@1732647|https://svn.apache.org/r1732647]) # OAK-4059: Tests in oak-lucene do not shut down repository (*b) (x) ([trunk@1732268|https://svn.apache.org/r1732268]) # OAK-4068: Align default value of suggestUpdateFrequencyMinutes to match documented 10 minutes (*y) (x) ([trunk@1732648|https://svn.apache.org/r1732648], [trunk@1732864|https://svn.apache.org/r1732864]) # OAK-4126: Suggestion and spellcheck queries throw exception if result contain lucene query character (*y) (x) ([trunk@1735052|https://svn.apache.org/r1735052], [trunk@1736176|https://svn.apache.org/r1736176]) We'd also need to update docs (*y) (x) ([trunk@1715717|https://svn.apache.org/r1715717], [trunk@1716588|https://svn.apache.org/r1716588], [trunk@1716590|https://svn.apache.org/r1716590], [trunk@1717655|https://svn.apache.org/r1717655], [trunk@1726331|https://svn.apache.org/r1726331], [trunk@1726332|https://svn.apache.org/r1726332]) (*y) - Required issues (*b) - Backported for dependency commit (x) - Not backported yet (/) - Backported was: Here's a list of improvements done for lucene based suggestions that were done for 1.4: # OAK-2754: Use non unique PathCursor in LucenePropertyIndex (*b) (/) ([trunk@1682488|https://svn.apache.org/r1682488], [1.2@1738061|https://svn.apache.org/r1738061]) # OAK-3230: Query engine should support virtual index rows (*y) (/) ([trunk@1697896|https://svn.apache.org/r1697896], [1.2@1738062|https://svn.apache.org/r1738062]) # OAK-3156: Allows suggestions to work on non-nt:base (*y) (/) ([trunk@1708307|https://svn.apache.org/r1708307], [1.2@1738063|https://svn.apache.org/r1738063]) # OAK-3509: Returns suggesion result per row (while this isn't really required, but it'd make other backports rather simple) (*y) (/) ([trunk@1715716|https://svn.apache.org/r1715716], [1.2@1738066|https://svn.apache.org/r1738066]) # OAK-3149: Uses one suggest dictionary per index definition. Useful when there are multiple indices supporting suggestions (*y) (/) ([trunk@1716100|https://svn.apache.org/r1716100], [1.2@1738068|https://svn.apache.org/r1738068]) # OAK-3407: Allows to have single work suggestions instead of phrases (*y) (/) ([trunk@1716588|https://svn.apache.org/r1716588], [trunk@1716589|https://svn.apache.org/r1716589], [trunk@1717203|https://svn.apache.org/r1717203], [1.2@1738069|https://svn.apache.org/r1738069]) # OAK-3692: java.lang.NoClassDefFoundError: org/apache/lucene/index/sorter/Sorter$DocComparator (*y) (/) ([trunk@1717410|https://svn.apache.org/r1717410], [1.2@1738070|https://svn.apache.org/r1738070]) # OAK-3838: Fixes issues of picking up a competing-non-suggest-capable index incorrectly to provide suggestions (*y) (/) ([trunk@1723565|https://svn.apache.org/r1723565], [1.2@1738073|https://svn.apache.org/r1738073]) # OAK-3825: Including Resource name to suggestions (*y) (/) ([trunk@1725941|https://svn.apache.org/r1725941], [1.2@1738074|https://svn.apache.org/r1738074]) # OAK-2477: Namespaced global configs for suggestions (*y) (x) ([trunk@1726237|https://svn.apache.org/r1726237]) # OAK-3994: Simple query on suggestion/spellcheck with unambiguous index def and one descendant clause should work (*y) (x) ([trunk@1729505|https://svn.apache.org/r1729505], [trunk@1729599|https://svn.apache.org/r1729599]) # OAK-4009: Search done via Lucene index might return duplicate results (*b) (x) ([trunk@1729957|https://svn.apache.org/r1729957]) # OAK-4070: Refactor LuceneIndexEditorContext to allow for switchable clock for testing (*b) (x) ([trunk@1732647|https://svn.apache.org/r1732647]) # OAK-4059: Tests in oak-lucene do not shut down repository (*b) (x) ([trunk@1732268|https://svn.apache.org/r1732268]) # OAK-4068: Align default value of suggestUpdateFrequencyMinutes to match documented 10 minutes (*y) (x) ([trunk@1732648|https://svn.apache.org/r1732648], [trunk@1732864|https://svn.apache.org/r1732864]) # OAK-4126: Suggestion and spellcheck queries throw exception if result contain lucene query character (*y) (x) ([trunk@1735052|https://svn.apache.org/r1735052], [trunk@1736176|https://svn.apache.org/r1736176]) We'd also need to update docs (*y) (x) ([trunk@1715717|https://svn.apache.org/r1715717], [trunk@1716588|https://svn.apache.org/r1716588], [trunk@1716590|https://svn.apache.org/r1716590], [trunk@1717655|https://svn.apache.org/r1717655], [trunk@1726331|https://svn.apache.org/r1726331], [trunk@1726332|https://svn.apache.org/r1726332]) (*y) - Required issues (*b) - Backported for dependency commit (x) - Not backported yet (/) - Backported > Collect and backport lucene based suggestion improvements done in 1.4 into > 1.2 branch > ------------------------------------------------------------------------------------- > > Key: OAK-4167 > URL: https://issues.apache.org/jira/browse/OAK-4167 > Project: Jackrabbit Oak > Issue Type: Task > Components: lucene > Reporter: Vikas Saurabh > Assignee: Vikas Saurabh > Priority: Minor > > Here's a list of improvements done for lucene based suggestions that were > done for 1.4: > # OAK-2754: Use non unique PathCursor in LucenePropertyIndex (*b) (/) > ([trunk@1682488|https://svn.apache.org/r1682488], > [1.2@1738061|https://svn.apache.org/r1738061]) > # OAK-3230: Query engine should support virtual index rows (*y) (/) > ([trunk@1697896|https://svn.apache.org/r1697896], > [1.2@1738062|https://svn.apache.org/r1738062]) > # OAK-3156: Allows suggestions to work on non-nt:base (*y) (/) > ([trunk@1708307|https://svn.apache.org/r1708307], > [1.2@1738063|https://svn.apache.org/r1738063]) > # OAK-3509: Returns suggesion result per row (while this isn't really > required, but it'd make other backports rather simple) (*y) (/) > ([trunk@1715716|https://svn.apache.org/r1715716], > [1.2@1738066|https://svn.apache.org/r1738066]) > # OAK-3149: Uses one suggest dictionary per index definition. Useful when > there are multiple indices supporting suggestions (*y) (/) > ([trunk@1716100|https://svn.apache.org/r1716100], > [1.2@1738068|https://svn.apache.org/r1738068]) > # OAK-3407: Allows to have single work suggestions instead of phrases (*y) > (/) ([trunk@1716588|https://svn.apache.org/r1716588], > [trunk@1716589|https://svn.apache.org/r1716589], > [trunk@1717203|https://svn.apache.org/r1717203], > [1.2@1738069|https://svn.apache.org/r1738069]) > # OAK-3692: java.lang.NoClassDefFoundError: > org/apache/lucene/index/sorter/Sorter$DocComparator (*y) (/) > ([trunk@1717410|https://svn.apache.org/r1717410], > [1.2@1738070|https://svn.apache.org/r1738070]) > # OAK-3838: Fixes issues of picking up a competing-non-suggest-capable index > incorrectly to provide suggestions (*y) (/) > ([trunk@1723565|https://svn.apache.org/r1723565], > [1.2@1738073|https://svn.apache.org/r1738073]) > # OAK-3825: Including Resource name to suggestions (*y) (/) > ([trunk@1725941|https://svn.apache.org/r1725941], > [1.2@1738074|https://svn.apache.org/r1738074]) > # OAK-2477: Namespaced global configs for suggestions (*y) (/) > ([trunk@1726237|https://svn.apache.org/r1726237], > [1.2@1738075|https://svn.apache.org/r1738075]) > # OAK-3994: Simple query on suggestion/spellcheck with unambiguous index def > and one descendant clause should work (*y) (x) > ([trunk@1729505|https://svn.apache.org/r1729505], > [trunk@1729599|https://svn.apache.org/r1729599]) > # OAK-4009: Search done via Lucene index might return duplicate results (*b) > (x) ([trunk@1729957|https://svn.apache.org/r1729957]) > # OAK-4070: Refactor LuceneIndexEditorContext to allow for switchable clock > for testing (*b) (x) ([trunk@1732647|https://svn.apache.org/r1732647]) > # OAK-4059: Tests in oak-lucene do not shut down repository (*b) (x) > ([trunk@1732268|https://svn.apache.org/r1732268]) > # OAK-4068: Align default value of suggestUpdateFrequencyMinutes to match > documented 10 minutes (*y) (x) > ([trunk@1732648|https://svn.apache.org/r1732648], > [trunk@1732864|https://svn.apache.org/r1732864]) > # OAK-4126: Suggestion and spellcheck queries throw exception if result > contain lucene query character (*y) (x) > ([trunk@1735052|https://svn.apache.org/r1735052], > [trunk@1736176|https://svn.apache.org/r1736176]) > We'd also need to update docs (*y) (x) > ([trunk@1715717|https://svn.apache.org/r1715717], > [trunk@1716588|https://svn.apache.org/r1716588], > [trunk@1716590|https://svn.apache.org/r1716590], > [trunk@1717655|https://svn.apache.org/r1717655], > [trunk@1726331|https://svn.apache.org/r1726331], > [trunk@1726332|https://svn.apache.org/r1726332]) > (*y) - Required issues > (*b) - Backported for dependency commit > (x) - Not backported yet > (/) - Backported -- This message was sent by Atlassian JIRA (v6.3.4#6332)