[ 
https://issues.apache.org/jira/browse/OAK-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Dürig resolved OAK-4054.
--------------------------------
       Resolution: Won't Fix
    Fix Version/s:     (was: 1.6)

Fix will only go into {{oak-segment-next}}

> FileStore.containsSegment returns alway true (almost)
> -----------------------------------------------------
>
>                 Key: OAK-4054
>                 URL: https://issues.apache.org/jira/browse/OAK-4054
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segmentmk
>            Reporter: Michael Dürig
>            Assignee: Michael Dürig
>            Priority: Critical
>              Labels: compaction, gc, stability
>
> {{FileStore.containsSegment()}} looks 
> [funky|https://github.com/mduerig/jackrabbit-oak/blob/36cb3bf6e5078e3afa75581fb789eeca7b5df2e2/oak-segment/src/main/java/org/apache/jackrabbit/oak/plugins/segment/file/FileStore.java#L1197-L1197].
>  This "optimisation" causes it to always return {{true}}. 
> {{containsSegment}} is used for deduplication and revision gc. The current 
> implementation causes {{SNFE}} exceptions once gc is effective (as I 
> experienced while working on OAK-3348). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to