[ https://issues.apache.org/jira/browse/OAK-4222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250389#comment-15250389 ]
angela commented on OAK-4222: ----------------------------- hmm... sounds odd. wouldn't it be better then to clear the options in the after-method? but now that you mention it: {{ExternalLoginModuleTest}} also hides the protected options provided from the base, while I didn't see this in the other derived tests.... nor is the finally-options.clear used consistently throughout the various derived tests. I think I will look at the blame tomorrow to see if I understand that :) > Cleanup ExternalLoginModuleTest > ------------------------------- > > Key: OAK-4222 > URL: https://issues.apache.org/jira/browse/OAK-4222 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: auth-external > Reporter: angela > Assignee: angela > Priority: Minor > Attachments: OAK-4222.patch > > > While looking at the tests present in oak-auth-external I found the > {{ExternalLoginModuleTest}} keeping it's own protected {{options}} map hiding > the {{options}} defined and populated in the setup of the base-class. > Not sure what this was intended to be used for but the fact that the options > get cleared in the finally-section of some of the test-cases looks quite > strange to me. > [~tripod], I would appreciate if you review the attached patch and let me > know if you think the proposed cleanup breaks the very intention of your > test-cases. Thanks a lot. -- This message was sent by Atlassian JIRA (v6.3.4#6332)