[ 
https://issues.apache.org/jira/browse/OAK-4211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15251264#comment-15251264
 ] 

Chetan Mehrotra commented on OAK-4211:
--------------------------------------

bq. IMO there shouldn't be anyone accessing the mapped segments any more once 
closed

Yes that should be the case. So far (before compaction is implemented) once a 
TarReader is opened and any SegmentNodeState is returned which is backed by a 
bytebuffer from that Tar then it was not possible to safely say when the reader 
can be closed. Now with current compaction logic I think all read should get 
routed to new segments and things should be fine

One place recently where we faced this issue was in OAK-4236 where per testcase 
a SegemtnNodeState remained alive and even after closing the FileStore and was 
preventing the cleanup of tar files as it held a file handle

> FileAccess.Mapped leaks file channels 
> --------------------------------------
>
>                 Key: OAK-4211
>                 URL: https://issues.apache.org/jira/browse/OAK-4211
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: segment-next
>            Reporter: Michael Dürig
>             Fix For: 1.6
>
>         Attachments: OAK-4211.patch
>
>
> {{FileAccess.Mapped}} seems to leak {{FileChannnel}} instances. The file 
> channels are acquired in the constructor but never release. 
> FYI [~alex.parvulescu], [~frm]



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to