[
https://issues.apache.org/jira/browse/OAK-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15260834#comment-15260834
]
Tobias Bocanegra edited comment on OAK-4268 at 4/27/16 8:02 PM:
----------------------------------------------------------------
I think there was not much thought put into defining when the identity could be
null.
I would really change the annotation. since the exact case when the identity
can be null was never explained, it doesn't really change the contract if we
make it stricter (if it would be the other ways around, i.e. allowing null all
of a sudden, it would be worse, and I wouldn't change it).
was (Author: tripod):
I think there was not much though put into when the identity could be null. I
would change the annotation. since the exact case when the identity can be null
was never explained, doesn't change the contract if we make it stricter (if it
would be the other ways around, i.e. allowing null all of a sudden, it would be
worse, and I wouldn't change it).
> Clarify API contract for SyncResult.getIdentity
> -----------------------------------------------
>
> Key: OAK-4268
> URL: https://issues.apache.org/jira/browse/OAK-4268
> Project: Jackrabbit Oak
> Issue Type: Improvement
> Components: auth-external
> Reporter: angela
> Assignee: Tobias Bocanegra
>
> [~tripod], I would appreciate if you could add some clarifying javadoc to
> {{SyncResult.getIdentity}} stating what the nature of the identity is
> expected to be for various status and what it means if the identity is
> {{null}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
