[ https://issues.apache.org/jira/browse/OAK-4279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313845#comment-15313845 ]
Alex Parvulescu commented on OAK-4279: -------------------------------------- introduced flags to enable and cap the size of binary content de-duplication with http://svn.apache.org/viewvc?rev=1746686&view=rev. we only have pending the issue related to adding the binary recordids to the cache. I see this as an improvement more than a bug, so I'd like to followup in a dedicated issue, so we can come back later and collect more numbers for the analysis. [~mduerig] agreed? > Rework offline compaction > ------------------------- > > Key: OAK-4279 > URL: https://issues.apache.org/jira/browse/OAK-4279 > Project: Jackrabbit Oak > Issue Type: Task > Components: segment-tar > Reporter: Michael Dürig > Assignee: Alex Parvulescu > Priority: Blocker > Labels: compaction, gc > Fix For: 1.6 > > Attachments: OAK-4279-binaries.patch, OAK-4279-checkpoints.patch, > OAK-4279-v0.patch, OAK-4279-v1.patch, OAK-4279-v2.patch, OAK-4279-v3.patch, > OAK-4279-v4.patch > > > The fix for OAK-3348 broke some of the previous functionality of offline > compaction: > * No more progress logging > * Compaction is not interruptible any more (in the sense of OAK-3290) > * Offline compaction could remove the ids of the segment node states to > squeeze out some extra space. Those are only needed for later generations > generated via online compaction. > We should probably implement offline compaction again through a dedicated > {{Compactor}} class as it was done in {{oak-segment}} instead of relying on > the de-duplication cache (aka online compaction). -- This message was sent by Atlassian JIRA (v6.3.4#6332)