[ https://issues.apache.org/jira/browse/OAK-4421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Mueller updated OAK-4421: -------------------------------- Attachment: OAK-4421-v3.patch Updated patch (incompatibilities fixed) > Optimize Revison fromString and toString implementation > ------------------------------------------------------- > > Key: OAK-4421 > URL: https://issues.apache.org/jira/browse/OAK-4421 > Project: Jackrabbit Oak > Issue Type: Improvement > Components: documentmk > Reporter: Chetan Mehrotra > Assignee: Chetan Mehrotra > Labels: performance > Fix For: 1.6 > > Attachments: OAK-4421-v1.patch, OAK-4421-v2.patch, OAK-4421-v3.patch, > hot-methods.png, revision-fromstring-caller.png > > > Current implementation of Revision {{fromString}} and {{toString}} make use > of std JDK API to perform string manipulation. While running some performance > test it was seen that these 2 methods are called quite frequently and that > adds up to some decent times. Further they also generate quite a bit of short > lived objects. > !hot-methods.png! > It would be worthwhile to perform a micro benchmark of these method and > optimize them further such that they perform better and also generate less > garbage. The micro optimized code would be bit more complex but if > performance numbers are better we can look into changing the current > implementation -- This message was sent by Atlassian JIRA (v6.3.4#6332)