[ 
https://issues.apache.org/jira/browse/OAK-1312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15387531#comment-15387531
 ] 

Chetan Mehrotra commented on OAK-1312:
--------------------------------------

Had an offline discussion with [~mreutegg] around current implemented approach. 
Couple of points to take care of

# Would the order of child node name returned via combined iterator matter?
# For conflict handling with current approach we might not get proper message 
for added-added and deleted-added kind of cases. But conflict would still be 
detected and reported as changed against base revision
# For conflict resolution we still need to take care of the bundled nodes. 
Currently when a child node is added/removed the  _children entry of parent is 
touched so as to detect hierarchy conflict (OAK-2151)
# Do away with {{afterPropertiesSet}} and replace that with a properties 
implementation which can be a custom map aware of bundling
# Look into way to ensure hasChildren optimization still works for bundled 
node. We can possibly get that info via pattern by have some marker to indicate 
that such nodes are leaf. But it would be better to avoid that as NodeStore 
should not enforce any structure

Open thing - Handling nodeType change!

> Bundle nodes into a document
> ----------------------------
>
>                 Key: OAK-1312
>                 URL: https://issues.apache.org/jira/browse/OAK-1312
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: core, documentmk
>            Reporter: Marcel Reutegger
>            Assignee: Chetan Mehrotra
>              Labels: performance
>             Fix For: 1.6
>
>
> For very fine grained content with many nodes and only few properties per 
> node it would be more efficient to bundle multiple nodes into a single 
> MongoDB document. Mostly reading would benefit because there are less 
> roundtrips to the backend. At the same time storage footprint would be lower 
> because metadata overhead is per document.
> Feature branch - 
> https://github.com/chetanmeh/jackrabbit-oak/compare/trunk...chetanmeh:OAK-1312



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to