[ 
https://issues.apache.org/jira/browse/OAK-4714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464846#comment-15464846
 ] 

Chetan Mehrotra commented on OAK-4714:
--------------------------------------

Thanks [~alex.parvulescu]. After discussion I realize that current setup is 
working as expected and no change is required

Given an async index /oak:index/fooIndex with reindex=true

# Sync commit - {{LuceneIndexEditorProvider}} would return null for editor call 
for reindex case. This would invoke the default 
{{MissingIndexEditorProviderStrategy}} would check if reindex flag is set. If 
yes then it would move on and let commit proceed. The strategy only fails 
commit if for any given commit reindex=false and no editor is found. Which is 
not the case here
# Async Commit - {{LuceneIndexEditorProvider}} would return an editor instance 
and no strategy would be invoked. Commit would proceed fine

Just that we would need to ensure that LuceneIndexEditor is registered with 
repository before any commit happens when any hybrid index is configured

> Reindexing should only happen in async mode for a mix mode index definition
> ---------------------------------------------------------------------------
>
>                 Key: OAK-4714
>                 URL: https://issues.apache.org/jira/browse/OAK-4714
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.5.8
>            Reporter: Chetan Mehrotra
>            Priority: Minor
>             Fix For: 1.6
>
>         Attachments: OAK-4714-v1.patch
>
>
> With OAK-4641 support was added for enabling use of same index definition for 
> both async and sync mode. This causes issue for reindexing as with this 
> change it would be attempted for both modes.
> Instead for a mixed mode index definition reindexing should be bounded to 
> only one of the modes and only for that mode reindexing should be performed. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to